Add proxy options #144
Add proxy options #144
Conversation
|
In general, our launcher loads endlessly, and since this function is in SETTINGS, it’s impossible to get there. Can this be fixed? |
SS14.Launcher/HappyEyeballsHttp.cs
Outdated
| @@ -16,7 +17,7 @@ public static class HappyEyeballsHttp | |||
| // This is the workaround. | |||
| // | |||
| // Implementation taken from https://github.com/ppy/osu-framework/pull/4191/files | |||
| public static HttpClient CreateHttpClient(bool autoRedirect = true) | |||
| public static HttpClient CreateHttpClient(bool autoRedirect = true, String ?proxyURL = null) | |||
There was a problem hiding this comment.
| public static HttpClient CreateHttpClient(bool autoRedirect = true, String ?proxyURL = null) | |
| public static HttpClient CreateHttpClient(bool autoRedirect = true, string? proxyURL = null) |
Formatting nit.
SS14.Launcher/HappyEyeballsHttp.cs
Outdated
| { | ||
| WebProxy webProxy = new WebProxy(proxyURL); | ||
| Uri proxyURLUri = new Uri(proxyURL); | ||
| Log.Debug(proxyURLUri.UserInfo); |
There was a problem hiding this comment.
Printing password to log is a very bad idea, comment this out.
| <Grid ColumnDefinitions="Auto,*"> | ||
| <CheckBox VerticalAlignment="Center" Margin="4" IsChecked="{Binding ProxyEnable}">Enable proxy</CheckBox> | ||
| <TextBox Grid.Column="1" Watermark="http://example.com:80" Text="{Binding ProxyURL}" /> | ||
| </Grid> | ||
| <TextBlock VerticalAlignment="Center" TextWrapping="Wrap" | ||
| Text="Proxy information for connect to hub and auth center." | ||
| Margin="8" /> |
There was a problem hiding this comment.
This should communicate that changing proxy settings requires launcher restart.
| WebProxy webProxy = new WebProxy(proxyURL); | ||
| Uri proxyURLUri = new Uri(proxyURL); |
There was a problem hiding this comment.
What happens if the proxy settings are malformed (invalid URL)? Does it cause the launcher to get stuck crashing on startup with broken config?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Hey! Are you still working on this? Would you mind if I took it off your hands? |
Added support using HTTP proxy for API requests
Allow enter address with credentials (ex. http://username:password@example.com:3128)