Driver reorganize #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To eliminate the "No SOURCES given to Zephyr library" warning displayed during the CMake run, we need to use the zephyr_library_amend() macro. However, this macro is only effective when the Zephyr driver hierarchy is followed. Moving zephyr/drivers to the top level achieves this. Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Replace zephyr_library() with zephyr_library_amend() to silent a build
warning like the following:
CMake Warning at .../scsat1-fsw/workspace/zephyr/CMakeLists.txt:915 (message):
No SOURCES given to Zephyr library: drivers__pwm
Excluding target from build.
CMake Warning at .../scsat1-fsw/workspace/zephyr/CMakeLists.txt:915 (message):
No SOURCES given to Zephyr library: drivers__spi
Excluding target from build.
This commit does not include drivers/misc. zephyr/driver/misc doesn't
call zephyr_library(). Thus, "No SOURCES" warning will not be
generated.
Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
yashi
force-pushed
the
driver-reorganize
branch
from
ab6fa19 to
69caa98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves drivers up to the top directory in order to remove build warnings.