Fix bugs on can driver #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is reformatting using Zephyr's `.clang-format`. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
This commit fixes the missing initialization of TX and RX mutexes. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
Currently, when the CAN IP core detects an arbitration lost while transmitting data, it calls the tx done callback. However, since the CAN IP core automatically retransmits upon detecting arbitration lost, a TX_DONE interrupt is also triggered, resulting in the tx_done callback being called twice for a single transmission frame. This commit removes the tx_done callback handling in case of arbitration lost. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
When a TX error interrupt occurs from the FPGA IP core, the status value returned to the upper layer is currently positive. This commit fixes it to a negative value. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the some bugs on CAN driver.