Fix temp sensor issue #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The I2C settings related to the temperature sensor were added to `uart1.overlay`, which is an optional overlay used for debugging purposes when UART1 is in use. Since data acquisition from the temperature sensor is required even when UART1 is not used, these settings will be moved to `app.overlay`. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
The temp sensor on the Payload Board of SC-Sat1 has a slave address of `4E`, so fixes it. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
If data acquisition from the temperature sensor fails, the CSP packet is not sent. In such cases, the CSP packet that was read needs to be released. If data acquisition succeeds, the packet is automatically released within `csp_send()`, so manual release is not necessary. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
Removes the unused defines. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
Updates the version for Pico to v1.0.1. Signed-off-by: Takuya Sasaki <takuya.sasaki@spacecubics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the temperature sensor implements added in the 2f93c95 on the SC-Sat1 Payload board, but it did not work.
Therefore, fixes the issue in this PR.
The primary cause was the difference in the I2C slave address.
In addition, this PR includes other improvements as well.