[ENG-1325] Vendor openssl in tauri #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
- Add OPENSSL_RUST_USE_NASM to force windows to use nasm
|
Release ran fine for this And the generated deb didn't link against libssl: So it should be ready to merge |
- Shouldn't change much as the openssl crates override was already dealing with the vendoring anyway
oscartbeaumont
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruct openssl crates to always use openssl-src-rs to vendor the libssl.3 and statically link against it. This avoids the libssl.1.1 vs libssl.3.0 linking problems in the deb release.
Partial fix for #1512