Don't include AWS cli in Gcloud version #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdeme
force-pushed
the
peterdeme-patch-1
branch
from
f6fd906
to
09c876a
Compare
peterdeme
commented
Mar 24, 2023
Signed-off-by: peterdeme <snypox@gmail.com>
peterdeme
force-pushed
the
peterdeme-patch-1
branch
from
09c876a
to
991fabc
Compare
adamconnelly
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason I've made this change is because the GCP flavor of this image currently has a broken AWS CLI installed.
I'm not sure why is it broken, but we use a different base image for GCP (
gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine- official Google one) and it doesn't seem to work nicely with AWS CLI. How come we didn't notice it? That's because we don't check if theawscli is executable during our build. 🤦 We only check it during pull request builds...I've decided that it does not make any sense to keep AWS CLI in the GCP image, so I did a bit of refactoring. We will use different targets in the Dockefile => this means that the GCP image will not include AWS cli anymore.
Changes:
v1.2.1). I've added a mechanism to create a new tag with scheduled releases as well:<semver>_<current-date>Oh and an important change: instead of testing the executables in the
build.ymlworkflow, we'll test it during the container building. This makes sure we avoid an issue which just happened: not noticing that the AWS cli is broken.