Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line 1: git: not found build issue #41

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix line 1: git: not found build issue #41

merged 1 commit into from
Apr 20, 2023

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Apr 19, 2023

I have introduced a bug in my previous PR. Apparently git is not present in the docker image by default. But why would we need to run in a container anyway? 🤷

https://github.com/spacelift-io/runner-terraform/actions/runs/4719056255/jobs/8369385968

@peterdeme peterdeme requested a review from a team April 19, 2023 09:18
Copy link

@damianstasik damianstasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, nothing seems to be needing the additional containerization.

@peterdeme peterdeme merged commit 848ef4d into main Apr 20, 2023
@peterdeme peterdeme deleted the fix-build branch April 20, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants