Add separate image with az cli
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msamendinger
changed the title
az cli
peterdeme
reviewed
May 4, 2023
peterdeme
reviewed
May 4, 2023
|
@msamendinger thanks for the contribution 🙏 I have some questions. |
peterdeme
reviewed
May 4, 2023
peterdeme
reviewed
May 4, 2023
peterdeme
requested changes
May 4, 2023
Merged
peterdeme
requested changes
May 4, 2023
There was a problem hiding this comment.
@msamendinger I noticed the "Build" job doesn't fire off. That's because your PR is outside of the spacelift organization. I have fixed it in this PR: #43
Do you mind rebasing your PR? It should work fine after that. 🙏
Yantrio
approved these changes
May 4, 2023
peterdeme
approved these changes
May 4, 2023
|
Sorry for all the hassle, I just saw that I haven't signed the commit and I was working under the wrong git account. I need to force push again. |
|
That's fine :D feel free to force push and we can re-approve. |
|
Should be good to go now @peterdeme @Yantrio |
Yantrio
approved these changes
May 4, 2023
peterdeme
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
azcli enabled image based on the latest officialaz-clidocker image published by Microsoft.mcr.microsoft.com/azure-cli:2.48.1
I tried to just extend your curent build process, more or less copying the gcp related parts.
New lines were added to the files I touched as requested here
If that's not consistent with the current guidelines I can remove them.