Allow for mTLS connections configured from environment #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
internal/cmd/authenticated/client.go
Outdated
|
|
||
| // configureTLS configures client TLS from the environment. | ||
| func configureTLS(httpClient *http.Client) error { | ||
| clientTLS := &tls.Config{} |
Check failure
Code scanning / Golang security checks by gosec
TLS MinVersion too low. Error
|
thanks for the contribution! can you fix the warning please? otherwise lgtm. |
Fixed! |
tomasmik
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an example PR for issue: #236 in which you can configure Client TLS settings through environment variables. Let me know if this is contribution you would be willing to accept or if I should request this feature through other channels.
Additionally, there might be improved UX if the client certs could be linked to a particular profile as well although I didn't explore that in this PR.