Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_fade invalid assert #8

Closed
dturpin74 opened this issue Feb 26, 2021 · 1 comment
Closed

add_fade invalid assert #8

dturpin74 opened this issue Feb 26, 2021 · 1 comment

Comments

@dturpin74
Copy link

dturpin74 commented Feb 26, 2021

seems like this line is problematic
dmx_channel.py line 91

assert 0 <= k.val_target <= 255 ** self._CHANNEL_SIZE

this does not work when using 16bit+ channels. The upper limit of fade value would be 65025 or 0xFE01 instead of the expected 0xFFFF

Value should be compared against (256 ** channel_size) - 1 instead

@spacemanspiff2007
Copy link
Owner

Thanks for your report - I'll fix it right away!

spacemanspiff2007 added a commit that referenced this issue Feb 26, 2021
- Fixed an issue with the max value for channels with 16bits and more (closes #8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants