Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestHare_ReconstructForward #6293

Closed
fasmat opened this issue Aug 27, 2024 · 0 comments
Closed

Flaky TestHare_ReconstructForward #6293

fasmat opened this issue Aug 27, 2024 · 0 comments

Comments

@fasmat
Copy link
Member

fasmat commented Aug 27, 2024

Description

Test failed in a PR without code changes.

Affected code

TestHare_ReconstructForward failed in this CI run: https://github.com/spacemeshos/go-spacemesh/actions/runs/10580781921/job/29316533825:

=== FAIL: hare4 TestHare_ReconstructForward (unknown)
2024-08-27T15:18:10.671Z	INFO	hare4/hare.go:280	registered signing key	{"id": "892c51"}
[202](https://github.com/spacemeshos/go-spacemesh/actions/runs/10580781921/job/29316533825#step:14:203)4-08-27T15:18:10.671Z	INFO	hare4/hare.go:300	started	{"enabled": false, "enabled layer": 0, "disabled layer": 4294967295, "committee": 50, "leaders": 5, "iterations limit": 4, "preround delay": "25s", "round duration": "12s", "log stats": true, "p2p protocol": "/h/4.0", "enabled": 8, "disabled": 4294967295}
2024-08-27T15:18:10.774Z	INFO	hare4/hare.go:280	registered signing key	{"id": "bcc78c"}
2024-08-27T15:18:10.774Z	INFO	hare4/hare.go:300	started	{"enabled": false, "enabled layer": 0, "disabled layer": 4294967295, "committee": 50, "leaders": 5, "iterations limit": 4, "preround delay": "25s", "round duration": "12s", "log stats": true, "p2p protocol": "/h/4.0", "enabled": 8, "disabled": 4294967295}
2024-08-27T15:18:10.791Z	INFO	hare4/hare.go:280	registered signing key	{"id": "5fd47e"}
2024-08-27T15:18:10.791Z	INFO	hare4/hare.go:300	started	{"enabled": false, "enabled layer": 0, "disabled layer": 4294967295, "committee": 50, "leaders": 5, "iterations limit": 4, "preround delay": "25s", "round duration": "12s", "log stats": true, "p2p protocol": "/h/4.0", "enabled": 8, "disabled": 4294967295}
2024-08-27T15:18:10.794Z	DEBUG	hare4/hare.go:309	notified	{"layer": 8}
2024-08-27T15:18:10.794Z	DEBUG	hare4/hare.go:309	notified	{"layer": 8}
2024-08-27T15:18:10.794Z	DEBUG	hare4/hare.go:309	notified	{"layer": 8}
2024-08-27T15:18:10.794Z	DEBUG	hare4/hare.go:599	registered layer	{"lid": 8}
2024-08-27T15:18:10.795Z	DEBUG	hare4/hare.go:599	registered layer	{"lid": 8}
2024-08-27T15:18:10.809Z	DEBUG	hare4/hare.go:642	active in preround. waiting for preround delay	{"lid": 8}
2024-08-27T15:18:10.809Z	DEBUG	hare4/hare.go:764	requested proposals	{"lid": 8, "beacon": "01010101"}
panic: layer 8 is not registered

goroutine 2286 [running]:
github.com/spacemeshos/go-spacemesh/hare4.TestHare_ReconstructForward.func1({0x23e4ba0, 0xc000427ea0}, {0xc000848848?, 0x40f0de?}, {0xc000244240, 0xbf, 0xbf})
	/home/runner/work/go-spacemesh/go-spacemesh/hare4/hare_test.go:1[216](https://github.com/spacemeshos/go-spacemesh/actions/runs/10580781921/job/29316533825#step:14:217) +0x57f
reflect.Value.call({0x1ceb960?, 0xc00051f2a0?, 0xc000849008?}, {0x1f03d72, 0x4}, {0xc00053de50, 0x3, 0x53f277?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/reflect/value.go:596 +0xd5d
reflect.Value.Call({0x1ceb960?, 0xc00051f2a0?, 0xc0008490a0?}, {0xc00053de50, 0x3, 0x3})
	/opt/hostedtoolcache/go/1.22.6/x64/src/reflect/value.go:380 +0xb6
go.uber.org/mock/gomock.(*Call).Do.func1({0xc0006a93b0, 0x3, 0xc0006046e0?})
	/home/runner/go/pkg/mod/go.uber.org/mock@v0.4.0/gomock/call.go:179 +0x852
go.uber.org/mock/gomock.(*Controller).Call(0xc0005fdc80, {0x1d3fe40, 0xc0006046e0}, {0x1f0751e, 0x7}, {0xc0006a93b0, 0x3, 0x3})
	/home/runner/go/pkg/mod/go.uber.org/mock@v0.4.0/gomock/controller.go:229 +0x11d
github.com/spacemeshos/go-spacemesh/p2p/pubsub/mocks.(*MockPublishSubscriber).Publish(0xc0006046e0, {0x23e4ba0, 0xc000427ea0}, {0x1f05a43, 0x6}, {0xc000244240, 0xbf, 0xbf})
	/home/runner/work/go-spacemesh/go-spacemesh/p2p/pubsub/mocks/publisher.go:171 +0x237
github.com/spacemeshos/go-spacemesh/hare4.(*Hare).onOutput(0xc000762c00, 0xc0004b9a80, {0x0?, 0x0?}, {0x0, {0x0, 0x0, 0x0}, 0x0, 0xc0000d0500})
	/home/runner/work/go-spacemesh/go-spacemesh/hare4/hare.go:734 +0xcb9
github.com/spacemeshos/go-spacemesh/hare4.(*Hare).run(0xc000762c00, 0xc0004b9a80)
	/home/runner/work/go-spacemesh/go-spacemesh/hare4/hare.go:653 +0x91d
github.com/spacemeshos/go-spacemesh/hare4.(*Hare).onLayer.func1()
	/home/runner/work/go-spacemesh/go-spacemesh/hare4/hare.go:601 +0x5e
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/home/runner/go/pkg/mod/golang.org/x/sync@v0.8.0/errgroup/errgroup.go:78 +0x92
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine [224](https://github.com/spacemeshos/go-spacemesh/actions/runs/10580781921/job/29316533825#step:14:225)3
	/home/runner/go/pkg/mod/golang.org/x/sync@v0.8.0/errgroup/errgroup.go:75 +0x125
spacemesh-bors bot pushed a commit that referenced this issue Aug 29, 2024
## Motivation

Fix flaky test.

Closes #6293.
spacemesh-bors bot pushed a commit that referenced this issue Aug 29, 2024
## Motivation

Fix flaky test.

Closes #6293.
spacemesh-bors bot pushed a commit that referenced this issue Aug 29, 2024
## Motivation

Fix flaky test.

Closes #6293.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant