[Merged by Bors] - ATX handler rejects invalid ATXs on pubsub lvl #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6142 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 302 302
Lines 32637 32642 +5
=======================================
+ Hits 26696 26701 +5
Misses 4203 4203
Partials 1738 1738 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Jul 16, 2024
|
Bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
## Motivation In order to drop peers sending invalid ATXs, the handler must return `pubsub.ErrValidationReject`
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
spacemesh-bors
bot
deleted the
fix/atx-handler-reject-syntactically-invalid
branch
fasmat
pushed a commit
that referenced
this pull request
Jul 22, 2024
In order to drop peers sending invalid ATXs, the handler must return `pubsub.ErrValidationReject`
4 tasks
fasmat
pushed a commit
that referenced
this pull request
Jul 22, 2024
In order to drop peers sending invalid ATXs, the handler must return `pubsub.ErrValidationReject`
fasmat
added a commit
that referenced
this pull request
Jul 22, 2024
* ATX handler rejects invalid ATXs on pubsub lvl (#6142) In order to drop peers sending invalid ATXs, the handler must return `pubsub.ErrValidationReject` * Update CHANGELOG.md --------- Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to drop peers sending invalid ATXs, the handler must return
pubsub.ErrValidationRejectDescription
Test Plan
updated tests
TODO