[Merged by Bors] - Speed up ATX cache warmup #6241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6241 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 308 308
Lines 34123 34138 +15
=======================================
+ Hits 28026 28043 +17
+ Misses 4321 4319 -2
Partials 1776 1776 ☔ View full report in Codecov by Sentry. |
poszu
changed the title
pigmej
approved these changes
Aug 12, 2024
fasmat
approved these changes
Aug 12, 2024
| ) | ||
| if err != nil { | ||
| return err | ||
| { |
There was a problem hiding this comment.
To add scope for local variables
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Speeding up the in-memory ATX cache warmup that is especially slow on HDDs. Co-authored-by: Jedrzej Nowak <pigmej@gmail.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Speeding up the in-memory ATX cache warmup that is especially slow on HDDs. Co-authored-by: Jedrzej Nowak <pigmej@gmail.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Speeding up the in-memory ATX cache warmup that is especially slow on HDDs. Co-authored-by: Jedrzej Nowak <pigmej@gmail.com>
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
fasmat
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Speeding up the in-memory ATX cache warmup that is especially slow on HDDs. Co-authored-by: Jedrzej Nowak <pigmej@gmail.com>
4 tasks
fasmat
added a commit
that referenced
this pull request
Aug 12, 2024
* Speed up ATX cache warmup (#6241) ## Motivation Speeding up the in-memory ATX cache warmup that is especially slow on HDDs. Co-authored-by: Jedrzej Nowak <pigmej@gmail.com> * Update CHANGELOG * Fix compiler error --------- Co-authored-by: Bartosz Różański <bartek.roza@gmail.com> Co-authored-by: Jedrzej Nowak <pigmej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Speeding up the in-memory ATX cache warmup that is especially slow on HDDs.
Description
Test Plan
Existing tests pass
TODO