Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 6243: removed redundant contextual validation in ATX V1 handler #6245

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 12, 2024

Motivation

Backport of #6243

Description

Only backport of #6243

Test Plan

  • n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.7%. Comparing base (f07c531) to head (0a1d2b8).
Report is 2 commits behind head on v1.6.

Files Patch % Lines
activation/handler_v2.go 33.3% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v1.6   #6245     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        301     301             
  Lines      32306   32290     -16     
=======================================
- Hits       26416   26396     -20     
- Misses      4170    4174      +4     
  Partials    1720    1720             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat enabled auto-merge (squash) August 12, 2024 21:01
@fasmat fasmat disabled auto-merge August 12, 2024 21:01
The removed check served no purpose. The actual contextual validation is implemented in `StoreAtx()`.
@fasmat fasmat enabled auto-merge (squash) August 12, 2024 21:03
@fasmat fasmat merged commit e1b52c2 into v1.6 Aug 12, 2024
22 of 23 checks passed
@fasmat fasmat deleted the backport-6243 branch August 12, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants