[Merged by Bors] - Fix incorrect permissions for release workflow #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6298 +/- ##
=======================================
Coverage 81.7% 81.8%
=======================================
Files 312 312
Lines 34625 34625
=======================================
+ Hits 28323 28325 +2
+ Misses 4469 4462 -7
- Partials 1833 1838 +5 ☔ View full report in Codecov by Sentry. |
|
As a test I created a release from this branch: https://github.com/spacemeshos/go-spacemesh/actions/runs/10598843935/job/29373031750 Seems to work fine 🙂 bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation The previous PR #6292 updated the wrong permission, this fixes this.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous PR #6292 updated the wrong permission, this fixes this.
Description
The
releasejob needswritepermissions instead of thebuild-and-uploadjob.Test Plan
Release works
TODO