Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - double-merge malfeasance proof #6339

Closed
wants to merge 80 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 18, 2024

Motivation

Closes #6341

Description

A malfeasance proof for when more than 1 merged ATX is published in a single epoch by a single equivocation set. Covers only the simple case when no checkpoint is involved. Support for checkpoint will come in following PRs

Test Plan

Added tests, skipped the test for when the first merged ATX is checkpointed - this should be IMO a syntactically invalid ATX.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@poszu poszu changed the title stub double-merge malfeasance proof double-merge malfeasance proof Sep 18, 2024
@poszu poszu marked this pull request as ready for review September 19, 2024 12:18
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (516fc47) to head (1871311).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
activation/wire/malfeasance_double_merge.go 77.1% 14 Missing and 7 partials ⚠️
activation/handler_v2.go 57.1% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6339     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.1%     
=========================================
  Files          343     344      +1     
  Lines        44505   44613    +108     
=========================================
+ Hits         35548   35632     +84     
- Misses        6952    6972     +20     
- Partials      2005    2009      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat force-pushed the add-invalid-post-malfeasance branch from 6349b9b to cb7ccaa Compare November 6, 2024 11:45
@spacemesh-bors spacemesh-bors bot changed the base branch from add-invalid-post-malfeasance to develop November 6, 2024 22:24
@fasmat
Copy link
Member

fasmat commented Nov 6, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 6, 2024
## Motivation

Closes #6341 



Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
@spacemesh-bors
Copy link

spacemesh-bors bot commented Nov 6, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title double-merge malfeasance proof [Merged by Bors] - double-merge malfeasance proof Nov 6, 2024
@spacemesh-bors spacemesh-bors bot closed this Nov 6, 2024
@spacemesh-bors spacemesh-bors bot deleted the atxmerge/double-merge-malfeasance-proof branch November 6, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create and publish double-merge malfeasance proof when no checkpoint is involved
2 participants