Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix the windows build artifacts name #6351

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix the windows build artifacts name #6351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile-libs.Inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ ifeq ($(GOOS),windows)
platform := windows
export PATH := $(PATH):$(BIN_DIR)
CGO_LDFLAGS := $(CGO_LDFLAGS) -Wl,-Bstatic -lpthread -Wl,-Bdynamic
EXE := .exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this from this file because it was not used anywhere and I didn't notice it's used in the Makefile that includes it. For this reason, in my opinion, EXE should be defined in the Makefile which uses it, not in this one.

else
TEMP := /tmp
ifeq ($(GOOS),darwin)
Expand Down
Loading