[PoC] Activation Service builds and publishes ATXs with Node Service help #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## node-split-poc #6355 +/- ##
==============================================
Coverage 79.0% 79.0%
==============================================
Files 336 336
Lines 44022 44030 +8
==============================================
+ Hits 34789 34799 +10
+ Misses 7226 7225 -1
+ Partials 2007 2006 -1 ☔ View full report in Codecov by Sentry. |
poszu
force-pushed
the
node-split/node-service
branch
from
d13ec92
to
9a09374
Compare
poszu
force-pushed
the
node-split/abstract-db-in-atx-builder
branch
from
11a68ea
to
378063b
Compare
Base automatically changed from
node-split/abstract-db-in-atx-builder
to
node-split-poc
October 29, 2024 19:51
poszu
requested review from
dshulyak,
fasmat,
ivan4th,
acud and
jellonek
as code owners
|
bors try |
acud
approved these changes
Oct 30, 2024
tryBuild succeeded: |
acud
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements step 2 of #6354.
Description
Test Plan
So far manual tests. The "client" go-spacemesh" successfully builds an ATX and tries to publish it via the node-service, which fails on the NodeService side because of missing PoET proof (expected).
TODO