Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node split: proposal building #6400

Open
wants to merge 52 commits into
base: node-split-poc
Choose a base branch
from

fix test

d6bb858
Select commit
Loading
Failed to load commit list.
Open

node split: proposal building #6400

fix test
d6bb858
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

77.3% (-0.7%) compared to a473494

View this Pull Request on Codecov

77.3% (-0.7%) compared to a473494

Details

Codecov Report

Attention: Patch coverage is 19.26910% with 486 lines in your changes missing coverage. Please review.

Project coverage is 77.3%. Comparing base (a473494) to head (d6bb858).
Report is 3 commits behind head on node-split-poc.

Files with missing lines Patch % Lines
miner/proposal_builder.go 0.0% 155 Missing ⚠️
miner/remote_proposals.go 0.0% 146 Missing ⚠️
api/node/client/client.gen.go 30.0% 42 Missing and 7 partials ⚠️
api/node/server/server.gen.go 44.1% 32 Missing and 6 partials ⚠️
api/node/client/client.go 29.1% 28 Missing and 6 partials ⚠️
node/node.go 58.1% 21 Missing and 2 partials ⚠️
api/node/server/server.go 46.8% 13 Missing and 4 partials ⚠️
hare3/remote.go 0.0% 13 Missing ⚠️
txs/conservative_state.go 0.0% 11 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           node-split-poc   #6400     +/-   ##
================================================
- Coverage            78.0%   77.3%   -0.7%     
================================================
  Files                 337     338      +1     
  Lines               44937   45497    +560     
================================================
+ Hits                35078   35204    +126     
- Misses               7780    8192    +412     
- Partials             2079    2101     +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov