Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - sync2: add sqlstore #6405

Closed
wants to merge 20 commits into from

Merge branch 'develop' into sync2/sqlstore

3750cb7
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - sync2: add sqlstore #6405

Merge branch 'develop' into sync2/sqlstore
3750cb7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 3, 2024 in 0s

79.8% (-0.1%) compared to 8f93588

View this Pull Request on Codecov

79.8% (-0.1%) compared to 8f93588

Details

Codecov Report

Attention: Patch coverage is 80.65693% with 106 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (8f93588) to head (3750cb7).

Files with missing lines Patch % Lines
sync2/rangesync/combine_seqs.go 74.8% 27 Missing and 9 partials ⚠️
sync2/sqlstore/dbseq.go 80.1% 15 Missing and 8 partials ⚠️
sync2/sqlstore/sqlidstore.go 41.9% 14 Missing and 4 partials ⚠️
sync2/sqlstore/syncedtable.go 91.8% 8 Missing and 4 partials ⚠️
sql/expr/expr.go 87.6% 8 Missing and 2 partials ⚠️
sync2/sqlstore/testdb.go 69.5% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6405     +/-   ##
=========================================
- Coverage     79.9%   79.8%   -0.1%     
=========================================
  Files          335     341      +6     
  Lines        43656   44204    +548     
=========================================
+ Hits         34892   35296    +404     
- Misses        6800    6915    +115     
- Partials      1964    1993     +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov