Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check size of the last POS file #31

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Apr 3, 2023

Previously it wrongly reported a corrupted POS data if the last file was smaller than max file size. It's fine, the last file can be smaller.

src/reader.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #31 (8504f76) into main (99f1358) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main     #31   +/-   ##
=====================================
  Coverage   96.7%   96.8%           
=====================================
  Files         12      12           
  Lines       1031    1033    +2     
=====================================
+ Hits         998    1000    +2     
  Misses        33      33           
Impacted Files Coverage Δ
src/reader.rs 99.2% <100.0%> (+<0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@poszu poszu marked this pull request as ready for review April 4, 2023 07:42
@poszu poszu merged commit dfb6355 into main Apr 4, 2023
@poszu poszu deleted the fix-notify-corrupted-files branch April 4, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant