added partial #49
Merged
added partial #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
===========================================
+ Coverage 41.20% 54.07% +12.86%
===========================================
Files 10 11 +1
Lines 216 307 +91
===========================================
+ Hits 89 166 +77
- Misses 127 141 +14 ☔ View full report in Codecov by Sentry. |
poszu
reviewed
Sep 27, 2024
Simplified partial_restore. Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
|
It's working well for me! |
poszu
requested changes
Sep 30, 2024
poszu
approved these changes
Oct 2, 2024
poszu
reviewed
Oct 7, 2024
| @@ -56,12 +56,23 @@ Listed below are the exit codes and what they mean: | |||
| - `7` - Invalid checksum of archive. | |||
| - `8` - Cannot validate archive checksum. | |||
|
|
|||
|
|
|||
| # Partial quicksync | |||
There was a problem hiding this comment.
Btw, how about naming it incremental?
There was a problem hiding this comment.
No big preference. I used "partial" because the existing one is "full".
poszu
approved these changes
Oct 7, 2024
poszu
approved these changes
Oct 9, 2024
Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing set the
QS_BASE_URLtohttp://quicksync-testnet-downloads.spacemesh.network/quicksync-pocfor now