Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use hash for Action workflow versions and update if needed #3205

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 27, 2024

As recommended by https://scientific-python.org/specs/spec-0008/#pin-github-actions-release-workflows-to-their-full-release-commit-shas , this PR changes your Actions workflow version pins to hashes, and updates to latest release hashes (at the time of writing) if needed.

This is an automated update made by the batchpr tool 🤖 - feel free to close if it doesn't look good! You can report issues to @pllim.

👻 🐱

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Sep 27, 2024
@kecnry kecnry added this to the 4.0 milestone Sep 27, 2024
@pllim pllim added the trivial Only needs one approval instead of two label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (c9425b8) to head (66745d8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         124      124           
  Lines       18541    18541           
=======================================
  Hits        16435    16435           
  Misses       2106     2106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why the diff is showing this whole file as changed? Might be nice to fix for blame/history, but also probably not a big deal 🤷‍♂️

Copy link
Contributor Author

@pllim pllim Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. The diff highlights look okay though. Maybe it is something subtle like \n vs \r\n, or <space> vs <tab>. I won't worry too much about it. But if you are worried, feel free to diff it locally and see. I'll let you decide when to merge in case you want to investigate. Thanks!

@kecnry kecnry merged commit 4efadec into spacetelescope:main Sep 30, 2024
28 of 30 checks passed
@pllim pllim deleted the action-ver-hash branch September 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants