Fix unit handling in continuum and moment calculations #3216
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
kecnry
reviewed
Oct 8, 2024
Comment on lines
-2973
to
+2974
| full_spectrum = self.app._jdaviz_helper.get_data(self.dataset.selected) | ||
| full_spectrum = self.app._jdaviz_helper.get_data(self.dataset.selected, | ||
| use_display_units=True) |
There was a problem hiding this comment.
I feel like @cshanahan1 had just removed this. Was there a reason for that or did it just not seem to affect that use-case (see https://github.com/spacetelescope/jdaviz/pull/3211/files#r1787615549)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 125 125
Lines 18751 18755 +4
=======================================
+ Hits 16606 16610 +4
Misses 2145 2145 ☔ View full report in Codecov by Sentry. |
|
In testing I am still seeing the traceback occur for moment zero (and it is occurring if you chose any spectral unit we allow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calculating moment 0 when display unit is in Hz, and more generally uses display unit more consistently in all continuum calculations.