Notebook for astroquery.mast JWST Metadata Search #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Thomas! I'm getting some errors in the Validation checker because of the cells that have exercises. Is it ok to leave those as they are since they're not really meant to be executed as is? |
|
@snbianco The best thing would be to comment out those lines. The validation results are pretty important since that's our main test for whether a notebook is still functional or needs to be replaced. Since this is an exercise, are you planning on including solutions? One other small comment: I think we should add an explicit warning at the top of the notebook that this API doesn't support data downloads yet. I know the title is "exploring metadata", but I can imagine someone missing that detail. Overall this notebook looks excellent! |
ttdu
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to search JWST metadata with
astroquery.mast.MastMissions!