Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanSTARRS 1 DR2 TAP notebook #64

Merged
merged 11 commits into from
Apr 2, 2019
Merged

Conversation

theresadower
Copy link
Contributor

This notebook parallels the MAST API notebook provided by @rlwastro via https://panstarrs.stsci.edu/.

All of the use cases from the API notebook are run using the TAP interface and astroquery TAPPlus here, as we have already done in providing the Hubble Source Catalog v3 notebook (github.com/spacetelescope/notebooks/.../MAST/HSC/HSC_TAP). The format from the HSC notebook was used as a template.

The notebook contents have been tested side-by side but should be checked again by someone familiar with the astronomical data and methods.

@astro-josh astro-josh requested a review from ceb8 March 4, 2019 17:29
Copy link
Collaborator

@ceb8 ceb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tutorial! I left a lot of comments, but most of them are just cosmetic.

The main non-cosmetic suggestion I had was to use the astroquery.mast Mast._resolve_object function. It's up to you if you want to make this transition, I realize it's using a "private" function, although I am planning to make it public/documented in future as it's become clear this is useful functionality.

notebooks/MAST/PanSTARRS/PS1_DR2_TAP/PS1_DR2_TAP.ipynb Outdated Show resolved Hide resolved
notebooks/MAST/PanSTARRS/PS1_DR2_TAP/PS1_DR2_TAP.ipynb Outdated Show resolved Hide resolved
notebooks/MAST/PanSTARRS/PS1_DR2_TAP/PS1_DR2_TAP.ipynb Outdated Show resolved Hide resolved
notebooks/MAST/PanSTARRS/PS1_DR2_TAP/PS1_DR2_TAP.ipynb Outdated Show resolved Hide resolved
notebooks/MAST/PanSTARRS/PS1_DR2_TAP/PS1_DR2_TAP.ipynb Outdated Show resolved Hide resolved
@theresadower
Copy link
Contributor Author

There is an earlier commit with accidentally included data inside the notebook. I'm not confident in my git skills and am OK with this being squashed as per the contributing guidelines.

theresadower and others added 11 commits April 2, 2019 15:35
- Added code to list available tables
- Decreased search radius for KQ UMa to 1 arcsec (was 1 arcmin)
Co-Authored-By: theresadower <dower@stsci.edu>
Had originally avoided astroquery.mast dependencies, but the notebook is already dependent on astroquery.utils, and this change removed some other dependencies the inline function had used.
From Greg Snyder, MASTVO-293 in JIRA
@ceb8 ceb8 merged commit 384c46d into spacetelescope:master Apr 2, 2019
@eteq
Copy link
Collaborator

eteq commented Apr 2, 2019

Hooray, it all worked!

Some backstory on the force push above: @theresadower and I just went through and did:

  1. rebased on master
  2. rebase -i to fix two commits where outputs were included in the notebook
  3. rebase -i to merge the several in-github edits into one commit

and clearly it all worked fine after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants