-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PanSTARRS 1 DR2 TAP notebook #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tutorial! I left a lot of comments, but most of them are just cosmetic.
The main non-cosmetic suggestion I had was to use the astroquery.mast
Mast._resolve_object
function. It's up to you if you want to make this transition, I realize it's using a "private" function, although I am planning to make it public/documented in future as it's become clear this is useful functionality.
There is an earlier commit with accidentally included data inside the notebook. I'm not confident in my git skills and am OK with this being squashed as per the contributing guidelines. |
- Added code to list available tables - Decreased search radius for KQ UMa to 1 arcsec (was 1 arcmin)
Co-Authored-By: theresadower <dower@stsci.edu>
Had originally avoided astroquery.mast dependencies, but the notebook is already dependent on astroquery.utils, and this change removed some other dependencies the inline function had used.
From Greg Snyder, MASTVO-293 in JIRA
Hooray, it all worked! Some backstory on the force push above: @theresadower and I just went through and did:
and clearly it all worked fine after that. |
This notebook parallels the MAST API notebook provided by @rlwastro via https://panstarrs.stsci.edu/.
All of the use cases from the API notebook are run using the TAP interface and astroquery TAPPlus here, as we have already done in providing the Hubble Source Catalog v3 notebook (github.com/spacetelescope/notebooks/.../MAST/HSC/HSC_TAP). The format from the HSC notebook was used as a template.
The notebook contents have been tested side-by side but should be checked again by someone familiar with the astronomical data and methods.