Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating logos to point to shared path #86

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Updating logos to point to shared path #86

merged 1 commit into from
Mar 21, 2019

Conversation

arfon
Copy link
Contributor

@arfon arfon commented Mar 21, 2019

Fixes #71

/ cc @pllim

@arfon arfon requested a review from astro-josh as a code owner March 21, 2019 15:27
@pllim
Copy link
Contributor

pllim commented Mar 21, 2019

Looks like we hit CircleCI max time limit but not related to this PR.

Too long with no output (exceeded 10m0s)

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arfon !

@pllim pllim merged commit 61a3314 into master Mar 21, 2019
@pllim pllim deleted the footer-png-updates branch March 21, 2019 19:05
pllim added a commit to pllim/notebooks that referenced this pull request Apr 8, 2019
astro-josh pushed a commit that referenced this pull request Apr 8, 2019
* Copy from DA5 notebooks

* Clean up NIRCam notebook, add requirements

* Address review comment

* Use logo added in #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants