-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Slack role #205
Added Slack role #205
Conversation
Info about using this bridge further can be found at https://github.com/matrix-org/matrix-appservice-slack It'll detail how to get the "control-room-id" (which is easy in Riot because you can just write any message in the control-room-channel and then use check-source) and how to invite the bot if you get that far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting on this! 👍
I haven't tested anything yet, but I've submitted some feedback based on what I saw from just reading the code.
I think it moves us in the right direction. Even if it doesn't completely make the bridge work, it should bring us to a point where we're almost there.
roles/matrix-bridge-appservice-slack/templates/systemd/matrix-appservice-slack.service.j2
Outdated
Show resolved
Hide resolved
@kingoftheconnors @spantaleev Is there anything in here that could be made easier by changes in the slack AS itself? I am currently making a bunch of changes to it, so I could fold in any feedback you have. One of the things I plan to add is making the path to the registration file configurable in the |
One thing that hurt organizationally was how the slack-registration file and databases had to be placed in a specific file together. If more freedom for where slack-registration and the database files could be found (such as saying "-d /data -f "/config" to signify looking for the databases in the /data file and the registration file in the /config file), that would help with organizing the files on the HS. Also, the documentation could be better. The significance of 8008 and homeserverURL vs inboundURI is never explained. |
Off the top of my head, I can't figure out why we need to pass |
@spantaleev it's the port the appservice listens on for pushes from synapse where as the HS url is the other way around? @kingoftheconnors Yeah, I will look into separating the config and the data, probably have the data locations specified in the config json. |
So it turns out there is a |
I added config for the HS registration file in matrix-org/matrix-appservice-slack#143 |
Once matrix-org/matrix-appservice-slack#143 gets merged, it looks like we should be able to add this to the configuration in dbdir: /data
hs_registration_file: ./registration.yaml This assumes that we've done the split into a I guess we also depend on:
Since As for |
I hope to push a new docker image for testing this week or next, and hopefully there will be a release of the slack AS itself in the next couple of weeks as well. |
Awesome. Be sure to drop a comment here to let us know when the docker update gets online! I can take care of the re-integration for it. |
According to matrix-org/matrix-appservice-slack#139, it looks like we may need to define |
Yes I think so. |
I have pushed a new docker image with the tag "cadair", it folds in a lot of my open PRs at the moment. It should have the latest updates to specifying the registration path via the cli |
matrix-org/matrix-appservice-slack#143 is merged fyi. |
Would that be |
@Cadair is |
Yes, you have to specify to the AS what port the HS is attempting to connect to. |
It should be |
So the bridge now can be reached, the proxied url (matrix.DOMAIN/appservice_slack) is reachable by the slack api, and I've been able to follow the directions by the appservice README, so a lot more progress has been made. Right now there's a problem in linking channels, since the bridge doesn't seem to recognize when channels are linked and just says |
I wonder if that's a bridge problem or something that's wrong with our configuration. |
I have also commented on the AS issue. Make sure that the bridge is getting events from synapse, specially the link commands. |
Looks like this might be fully functional now, given that networking has been fixed? |
Networking has been fixed. There's a small to-do list left though:
|
Also, the slack role doesn't implement the |
It works! Maybe try it out yourself, but if my bridge is anything to go off of, the slack role is functional! ... Although it still uses the |
Now 0.3 is out I should rebuild the latest image. Although I should find out about the official docker image as well. |
The latest tag of the docker image is now the master branch of the repo, which is the 0.3 release. So we should be good to go. I have had a read over this and it looks great. I might try and deploy it on my personal server today. |
It seems media_URL may be wrong, since the profile pics aren't being bridged. I'll be taking a look at this later today. |
Alright, fixed! I just forgot to update my docker image. 😆 |
roles/matrix-bridge-appservice-slack/templates/systemd/matrix-appservice-slack.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bridge-appservice-slack/templates/systemd/matrix-appservice-slack.service.j2
Show resolved
Hide resolved
roles/matrix-bridge-appservice-slack/templates/systemd/matrix-appservice-slack.service.j2
Show resolved
Hide resolved
Seems like this is coming along nicely! Thank you for all the hard work @kingoftheconnors and @Cadair! |
Anything else that needs to be done before this gets merged? |
Not right now. There's currently work for an official docker image for the appservice, but that probably won't be up for a while. Once that's up, I'll probably open a new PR for that one. This role works and I'm using it for my own server as we speak! |
There is already an official image for develop, just not stable yet.
…On 18 August 2019 17:47:59 BST, kingoftheconnors ***@***.***> wrote:
Not right now. There's currently work for an official docker image for
the appservice, but that probably won't be up for a while. Once that's
up, I'll probably open a new PR for that one. This role works and I'm
using it for my own server as we speak!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#205 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Hm. Should we wait for that to stabilize or move over to that one now? |
I will check with Halfy.
…On 18 August 2019 17:54:00 BST, kingoftheconnors ***@***.***> wrote:
Hm. Should we wait for that to stabilize or move over to that one now?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#205 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
I suggest we stay with this one until we get a stable release of the official image. I think this is ready to merge. |
It's been a long ride, but I'm happy to finally merge this, so that everyone could start bridging to Slack easily! Thank you for the great work and perseverance! 👍 Announced in dd0f355. |
This is a role for using Matrix-Appservice-Slack.
There is no documentation yet, but to use it you need to define
slack_control_room_id
andmatrix_appservice_slack_enabled
in the inventory/host_vars/.../vars.yml file.The
--tags=setup-all
andstart
work fine, but if you check thejournalctl -fu matrix-appservice-slack
you'll PROBABLY get aUnhandled rejection Error: connect ECONNREFUSED
error. The matrix port connects to the homeserver itself, similar to the discord appservice and is right now set to 8008.After I settle a few other projects, I hope to cycle back to this, but feel free to give it a whirl if you want!