Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the old workaround for an Ansible bug that has been fixed three years ago #743

Merged
merged 2 commits into from
Jan 3, 2021

Conversation

pushytoxin
Copy link
Contributor

This PR cleans up an old workaround.

No issues running like this for at least six months.

$ ansible --version
ansible 2.9.13
...

@pushytoxin
Copy link
Contributor Author

What versions of Ansible does the playbook support (what versions of Ansible are people using with the playbook)?

@aaronraimist
Copy link
Contributor

@pushytoxin
Copy link
Contributor Author

The fix was backported and appears in Ansible tags v2.6.8 and v2.7.1

Delay merging this until the minimum supported ansible version gets bumped to v2.7.1 then.

spantaleev added a commit that referenced this pull request Jan 3, 2021
@spantaleev spantaleev merged commit 8710883 into spantaleev:master Jan 3, 2021
@spantaleev
Copy link
Owner

I guess distros that are on 2.7.x should have 2.7.1 (or newer) available to them, so we may bump the requirements.

I've tested these distros and the version of Ansible in their default repositories as of right now (2021-01-03):

  • Ubuntu 16.04: Ansible 2.0.0.2 on Python 2.7.12
  • Ubuntu 16.10: could not check; non-LTS and too old, so repositories have been moved to archive or something
  • Ubuntu 18.04: Ansible 2.5.1 on Python 2.7.17
  • Ubuntu 18.10: could not check; non-LTS and too old, so repositories have been moved to archive or something
  • Ubuntu 20.04: Ansible 2.9.6 on Python 3.8.5
  • Ubuntu 20.10: Ansible 2.9.9 on Python 3.8.6
  • Debian 9: Ansible 2.2.1.0 on Python 2.7.13
  • Debian 10: Ansible 2.7.7 on Python 3.7.3
  • Centos 7: Ansible 2.9.16 on Python 2.7.5

Seems like most distros either have newer than 2.7.1 or are on a too-old version (in which case people either run Ansible in Docker or can install newer via pip or something).

I've bumped the minimum Ansible version to 2.7.1 in 6e652e1 and 2c09111, and have merged this!

Thank you! 👍

@pushytoxin pushytoxin deleted the docker_network branch May 28, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants