Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5.x] USB Serial implementation backport #1073

Merged
merged 11 commits into from
Aug 3, 2016
Merged

[0.5.x] USB Serial implementation backport #1073

merged 11 commits into from
Aug 3, 2016

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Jul 31, 2016 •
edited by technobly
Loading

  • Almost 1-1 USB CDC driver implementation backport from develop, without composite support:
    • DTR/RTS support (open/closed detection: Serial.isConnected())
    • Fixes the issue of USB Serial erroneously switching to closed state
    • Various other small fixes and improvements
  • Cleaned up old USB HAL (USB_USART_) functions to behave like their new (HAL_USB_) counterparts in 0.6.x
  • Added wiring/usbserial tests:
    • 0_USBSERIAL_RingBufferHelperIsSane
    • 1_USBSERIAL_ReadWrite
    • 2_USBSERIAL_isConnectedWorksCorrectly
    • 3_USBSERIAL_RxBufferFillsCompletely

This PR includes #1072

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation

DTR/RTS support (open/closed detection: Serial.isConnected()) will be since 0.5.3

  • Add to CHANGELOG.md after merging (add links to docs and issues)

FEATURE

  • DTR/RTS support (open/closed detection: Serial.isConnected()). #1073

BUGFIX

  • Fixes an issue of USB Serial erroneously switching to closed state. #1073

@avtolstoy avtolstoy force-pushed the feature/usb-serial-0.5.x-backport branch from 0e6ce4b to 3e057b2 Compare August 1, 2016 15:52
@avtolstoy avtolstoy force-pushed the feature/usb-serial-0.5.x-backport branch from 3e057b2 to fd1d86d Compare August 2, 2016 13:06
@avtolstoy avtolstoy mentioned this pull request Aug 2, 2016
Merged
7 tasks
@technobly technobly merged commit f78536d into develop-0.5.x Aug 3, 2016
@technobly technobly added this to the 0.5.3 milestone Aug 3, 2016
@technobly technobly deleted the feature/usb-serial-0.5.x-backport branch October 27, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@avtolstoy @technobly @m-mcgowan