RGB LED mirroring #1204
Merged
RGB LED mirroring #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove from linker file. Add hal_rgbled dynalib to photon system-part2
…sh when built with gcc 4.8.4
Conflicts: hal/src/stm32f2xx/hal_dynalib_export.cpp modules/photon/system-part2/module_system_part2_export.ld modules/photon/system-part2/src/module_system_part2.cpp
technobly
approved these changes
Dec 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1113
Wiring functions added:
RGB.mirrorTo(pin_t rpin, pin_t gpin, pin_t bpin, bool invert=false, bool bootloader=false)RGB.mirrorDisable(bool bootloader=true)Relevant tests:
wiring/no_fixture:LED_11_MirroringWorksTODO: Documentation
Doneness:
Features
RGB.mirrorTo(). Common Anode/Cathode LED and Bootloader compatible. See PR for usage.