Future API fixes #1245
Merged
Future API fixes #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() overflow; minor refactoring; more unit tests
…pletionHandlerMap
…d() methods now wait until future is completed; few more convenience methods and conversion operators; minor renamings
Conflicts: wiring/inc/spark_wiring_cloud.h wiring/src/spark_wiring_cloud.cpp
technobly
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
isSucceeded(),isFailed(),result()anderror()methods ofFuture<T>now synchronously wait until an operation is completed.Future<T>now can be implicitly (and synchronously) converted toT.Particle.publish()now returnsFuture<bool>and can be used in a backward-compatible way.HAL_Timer_Milliseconds()overflow is now properly handled when checking for expired ACK handlers (WITH_ACKflag functionality).CompletionHandlerListclass that can be used to invoke several completion handlers at once (@avtolstoy).Promiseclass toSystemPromiseto avoid conflicts with application'sPromisein the global namespace.Doneness:
Features
[PR #1245]Particle.publish()now able to use Future API