DHCP hostname support #1296
Merged
DHCP hostname support #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mcgowan
approved these changes
Apr 11, 2017
avtolstoy
force-pushed
the
feature/photon/wiced-3.7.0-7
branch
from
ee6f58b to
3ef4ffc
Compare
avtolstoy
force-pushed
the
feature/dhcp-hostname
branch
from
382d5f3 to
e7fdc4a
Compare
avtolstoy
force-pushed
the
feature/dhcp-hostname
branch
2 times, most recently
from
49f5cba to
e7fdc4a
Compare
avtolstoy
added a commit
to avtolstoy/firmware
that referenced
this pull request
May 10, 2017
DHCP hostname support
avtolstoy
added a commit
to particle-iot/docs
that referenced
this pull request
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1251.
Solution
This PR changes the default hostname to device id and also adds support for setting a custom DNS hostname.
Added Wiring methods:
WiFi.hostname()WiFi.setHostname()Steps to Test
wiring/no_fixtureincludes a set of tests for this feature.Example App
N/A
References
Completeness
Bugfix
[PR #1296][Fixes #1251][Photon/P1]Default Wi-Fi DNS hostname changed to device ID, to avoid spaces in name which may cause issues.Enhancement
[PR #1296][Photon/P1]Added support for setting a custom DNS hostname, default is device ID.