Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed extraneous include of math.h in spark_wiring_arduino.h - we only want to include it when Arduino compatibility is enabled (via Arduino.h)
Problem
math.h was being included, plus a check for isnan being a defined symbol. This will fail if
<algrithm>
has already been included before the header.Solution
Only include math.h when Arduino compatibility is requested. (math.h was not included in 0.6.0).
Steps to Test
Run the firmware library compile script to validate all libraries that compiled with 0.6.0 continue to compile with this PR. (this has been done.)
Completeness
Bug fix
<algorithm>
has already been included before themath.h
header. Now we only includemath.h
when Arduino compatibility is requested. (math.h was not included in 0.6.0).