Process USB vendor requests in system thread #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… system thread. USB_REQUEST_MODULE_INFO added
sergeuz
requested changes
May 8, 2017
system/src/system_control.cpp
Outdated
| @@ -181,10 +170,13 @@ uint8_t SystemControlInterface::handleVendorRequest(HAL_USB_SetupRequest* req) { | |||
| } else { | |||
| // Return as string | |||
| String id = System.deviceID(); | |||
system/inc/system_control.h
Outdated
| @@ -66,6 +67,7 @@ typedef enum USBRequestResult { | |||
| typedef struct USBRequest { | |||
| size_t size; // Structure size | |||
| int type; // Request type (as defined by USBRequestType enum) | |||
| uint16_t value; // wValue field | |||
There was a problem hiding this comment.
This change breaks ABI (new fields should be added at the end of the structure)
| @@ -279,6 +279,7 @@ class ManagedNetworkInterface : public NetworkInterface | |||
| console.loop(); | |||
| } | |||
| #if PLATFORM_THREADING | |||
| SystemISRTaskQueue.process(); | |||
system/src/system_control.cpp
Outdated
| } | ||
|
|
||
| case USB_REQUEST_LISTENING_MODE: { | ||
| setRequestResult(req, result); |
There was a problem hiding this comment.
Is there any problem with setting a result after calling WiFi.listen()? I just would like to see error handling unified in this function (if possible), i.e. make all case blocks to either call setRequestResult() and return, or assign to result variable.
system/src/system_control.cpp
Outdated
| default: | ||
| if (usbReqAppHandler) { | ||
| processAppRequest(data); // Forward request to the application thread | ||
| } else { | ||
| setRequestResult(req, USB_REQUEST_RESULT_ERROR); | ||
| } | ||
| return; |
There was a problem hiding this comment.
Same here:
if (usbReqAppHandler) {
processAppRequest(data);
return;
} else {
result = USB_REQUEST_RESULT_ERROR;
}
|
Thanks for the comments! Updated PR. |
…sb vendor requests
sergeuz
approved these changes
May 9, 2017
avtolstoy
pushed a commit
to avtolstoy/firmware
that referenced
this pull request
May 10, 2017
…quest-sync Process USB vendor requests in system thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Most of the currently supported vendor requests should be executed on system thread instead of being processed in ISR.
Solution
Utilize
SystemISRTaskQueuefor vendor requests.Steps to Test
N/A
Example App
N/A
References
Completeness
Internal
[PR #1323]USB vendor requests should be executed on system thread instead of being processed in ISR.