Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes monolithic builds on:
feature/photon/wiced-3.7.0-7
branch due to WICED upgrade and an oversight)Solution
#if MODULAR_FIRMWARE
checks to#if defined(MODULAR_FIRMWARE) && MODULAR_FIRMWARE
, to avoid triggering an error with-Wundef
which is now always enabledLib_crypto_open.a
on Photon/P1 in monolithic buildssha4
functions inLib_crypto_open.a
Steps to Test
Build Photon and Electron firmware in modular and monolithic.
Example App
N/A
Completeness
Bug fix
[PR #1340]
[Electron]
Fixes the monolithic build