Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multi-host support #2

Open
Pinolo opened this issue Jan 28, 2022 · 2 comments
Open

Remove multi-host support #2

Pinolo opened this issue Jan 28, 2022 · 2 comments
Assignees
@Pinolo

Comments

@Pinolo
Copy link
Contributor

Pinolo commented Jan 28, 2022

No description provided.

@Pinolo Pinolo self-assigned this Jan 28, 2022
@Pinolo
Copy link
Contributor Author

Pinolo commented Jan 29, 2022

@andypanix @paolomainardi I think now I understand you used a submodule in order to support multiple hosts, but since the main module is itself reusable, this could be left to module consumers. Also, if you allow multiple hosts it's not safe to assume the path is the same. I'm renaming the issue to make scope clear

@Pinolo Pinolo changed the title Remove submodule Remove multi-host support Jan 29, 2022
Pinolo pushed a commit that referenced this issue Jan 29, 2022
#2 removing multi-host support
22e9a72
@Pinolo
Copy link
Contributor Author

Pinolo commented Jan 29, 2022

Also, for the module to be fully reusable, we should not configure the google provider

Pinolo pushed a commit that referenced this issue Jan 29, 2022
#2 removing provider configuration
fbc64ab
Pinolo pushed a commit that referenced this issue Jan 29, 2022
ref #2 removing provider configuration
281e76b
Pinolo pushed a commit that referenced this issue Jan 29, 2022
ref #2 removing provider configuration
dda169f
andypanix added a commit that referenced this issue Apr 20, 2022
@Pinolo @andypanix
#2 removing multi-host support (#3)
56c17dd 
* #2 removing multi-host support

* ref #2 removing provider configuration

* Added tflint check and CHANGELOG

* Start pipeline on PR commits

Co-authored-by: Andrea Panisson <andrea.panisson@sparkfabrik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pinolo Pinolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pinolo