Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test tooling #49

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

JBurkinshaw
Copy link
Collaborator

Description

Add vitest, testing-library and jsdom packages.
Update configuration files.
Add setupTests.ts.
Add example test for Swatch component.
Add error handling to lint-staged config.
Worked out some outstanding TS issues.

Related issue: #27

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Instructions

Run npm run test

Add vitest, testing-library and jsdom packages.
Update configuration files.
Add setupTests.ts.
Add example test for Swatch component.
Add error handling to lint-staged config.
Worked out some outstanding TS issues.

Ref: #27
@JBurkinshaw JBurkinshaw requested a review from atweedie October 25, 2024 01:48
Copy link
Collaborator

@atweedie atweedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully we'll be more able to fetch elements semantically when we start making more use of React Aria

@JBurkinshaw JBurkinshaw marked this pull request as ready for review November 5, 2024 23:54
@JBurkinshaw JBurkinshaw merged commit 9d4fe0e into 41-enable-typescript Nov 5, 2024
@JBurkinshaw JBurkinshaw deleted the 27-test-tooling branch November 5, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants