Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when running checkForUpdates() #2560

Closed
YoavGro opened this issue May 12, 2024 · 2 comments · Fixed by #2561
Closed

Crash when running checkForUpdates() #2560

YoavGro opened this issue May 12, 2024 · 2 comments · Fixed by #2561

Comments

@YoavGro
Copy link

YoavGro commented May 12, 2024

Description of the problem

Crash from user on checkForUpdates()

Assertion failed: (_driver == nil), function -[SPUUpdater checkForUpdatesWithDriver:updateCheck:installerInProgress:], file SPUUpdater.m, line 698.

Do you use Sandboxing in your app? No

Version of Sparkle.framework in the latest version of your app 2.6.2

Version of Sparkle.framework in the old version of app that your users have (or N/A) 2.6.2

Sparkle's output from Console.app

Don't know, this was from crash report

Steps to reproduce the behavior

N/A

[The more information provided and pasted verbatim, the easier it will be to diagnose an issue. If you can provide the affected application/binary and XML feed to reproduce an issue, share them]
@zorgiepoo
Copy link
Member

zorgiepoo commented May 12, 2024 •
edited
Loading

Do you have backtraces of all the threads? Is everything Sparkle related on the main thread? Do you only call checkForUpdates based on user initiation?

zorgiepoo added a commit that referenced this issue May 12, 2024
@zorgiepoo
Guard update timer update check against sessionInProgress
5b403be 
Make sure we don't perform a background update check when a user update check was initiated. This may have regressed from #2295.

Also replaces an assert with an error log if the _driver already exists.

Fixes #2560
@zorgiepoo zorgiepoo mentioned this issue May 12, 2024
Merged
6 tasks
zorgiepoo added a commit that referenced this issue May 12, 2024
@zorgiepoo
Guard update timer update check against sessionInProgress (#2561)
be8247e 
Make sure we don't perform a background update check when a user update check was initiated. This may have regressed from #2295.

Also replaces an assert with an error log if the _driver already exists.

Fixes #2560
@zorgiepoo
Copy link
Member

zorgiepoo commented May 12, 2024 •
edited
Loading

I believe I found a rare potential race in #2561. I also replaced the assert with a log here to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guard update timer update check against sessionInProgress sparkle-project/Sparkle
2 participants
@zorgiepoo @YoavGro