Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template and update issue templates #1727

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

zorgiepoo
Copy link
Member

These changes require development changes to be made on 2.x branch first. This is separate from changing the default branch, which can happen and be done independently.

On the repo level, I also want to protect master and 2.x from direct pushes because inevitably it's tempting to push changes directly that should be reviewed -- and changes that get integrated that way are less pleasant to track.

And I want to require a minimum of two project members to review PR changes (with a reasonable bypass for trivial bug-fixes, localization or doc updates or critical things that should rarely be the case). With that, I will put a commitment in reviewing changes here, and this would result in less work for project members and better quality review.

(Note PR / issue templates must be pushed to default branch, currently master).

These changes require development changes to be made on 2.x branch first. This is separate from changing the default branch, which can happen and be done independently.

On the repo level, I also want to protect master and 2.x from direct pushes because inevitably it's tempting to push changes directly that should be reviewed -- and changes that get integrated that way are less pleasant to track.

And I want to require a minimum of two project members to review PR changes (with a reasonable bypass for trivial bug-fixes, localization or doc updates). With that, I will put a commitment in reviewing changes here, and this would result in less work for project members and better quality review.
@kornelski kornelski merged commit dfecd4d into sparkle-project:master Jan 19, 2021
@zorgiepoo
Copy link
Member Author

Thanks. As discussed @kornelski I enabled two changes:

  1. Two approvers (usually us) are required for future and on-going PRs
  2. Locked master and 2.x from direct pushes (so create PRs)

In theory we can probably bypass this for special cases, but in spirt let's try not to normally and see how this works out. (One exception may be if a PR comes from either one of us, then only 1 approval is sufficient)

I'm going to clean up some of the other stale PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants