Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let status window make other active windows exit in stage manager #2153

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Jun 12, 2022

We set the status window's collection behavior to full screen auxiliary. This is how the collection behavior for the update alerts and permission prompts are set up, but we never applied it to the status window.

With this change, bringing the status window up front (e.g, for downloading an update) does not push the other app's windows back into the stage manager tiles.

Note Stage Manager is a new feature in macOS 13 (Ventura).

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Testing with the test app.

macOS version tested: [place version here]

We set the status window's collection behavior to full screen auxiliary. This is how the collection behavior for the update alerts and permission prompts are set up, but we never applied it to the status window.

With this change, bringing the status window up front (e.g, for downloading an update) does not push the other app's windows back into the stage manager tiles.
@zorgiepoo zorgiepoo added this to the 2.2 milestone Jun 12, 2022
@zorgiepoo
Copy link
Member Author

zorgiepoo commented Jun 12, 2022

#1592 was where we applied this collection behavior to the update alert window cc @R4N . I think it makes sense to apply it to all of our windows.

@zorgiepoo zorgiepoo merged commit 6808a94 into 2.x Jun 12, 2022
@zorgiepoo zorgiepoo deleted the stage-manager-fix branch June 12, 2022 22:19
@zorgiepoo zorgiepoo changed the title Don't let status window push other windows behind in stage manager Don't let status window make other active windows exit in stage manager Jun 12, 2022
@R4N
Copy link
Contributor

R4N commented Jun 13, 2022

@zorgiepoo Yup, makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants