Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up left-over code #2243

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Clean up left-over code #2243

merged 3 commits into from
Aug 27, 2022

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Aug 27, 2022

This cleans up some left-over code from #2111 and #2196.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Since removing the SUTouchBarForwardDeclarations header it is not necessary to reference NSTouchBar/NSCustomTouchBarItem with NSClassFromString.
@Eitot Eitot changed the title Deprecations Clean up left-over code Aug 27, 2022
@zorgiepoo zorgiepoo added this to the 2.3 milestone Aug 27, 2022
@zorgiepoo
Copy link
Member

Thanks.

@zorgiepoo zorgiepoo merged commit 863f85b into sparkle-project:2.x Aug 27, 2022
@Eitot Eitot deleted the deprecations branch August 27, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants