Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -p option to sign_update to only print the signed signature #2268

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Sep 18, 2022

Related to discussion #2263

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested running sign_update with and without -p option.
Validated -p and --verify options cannot be passed together.

macOS version tested: 12.5.1 (21G83)

@zorgiepoo zorgiepoo added this to the 2.3 milestone Sep 18, 2022
@zorgiepoo zorgiepoo merged commit a208bd5 into 2.x Sep 18, 2022
@zorgiepoo zorgiepoo deleted the sign-update-signature-only branch September 18, 2022 14:18
@tonyarnold
Copy link
Contributor

This is excellent, @zorgiepoo - exactly what I needed - thank you! Sorry that I didn't get time to review the changes before merging - it all looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants