Fix error formatting bug in HTTP::CookieJar::AbstractStore

[andrelaszlo]

Before this patch is applied, the new test will fail:

     10:     end
     11: 
     12:     def test_nonexistent_store_in_config
  => 13:       assert_raise_with_message(
     14:         ArgumentError,
     15:         /cookie store unavailable: :nonexistent, error: cannot load .*nonexistent_store/
     16:       ) {
<ArgumentError> expected but was
<ArgumentError(<too few arguments>)

The bug seems to have been introduced a while back.

This line:

raise IndexError, 'cookie store unavailable: %s, error: %s' % symbol.inspect, e.message

Will be parsed as:

(send nil :raise
  (const nil :IndexError)
  (send
    (str "cookie store unavailable: %s, error: %s") :%
    (send
      (send nil :symbol) :inspect))
  (send
    (send nil :e) :message))

This means that the message will be passed as an argument to the IndexError initializer instead of to %.

If self contains multiple substitutions, object must be an Array or Hash containing the values to be substituted

String#% docs

[andrelaszlo]

We ran into this spurious issue when the HashStore wasn't in the @@class_map - likely an issue due to, or similar to #27.

[andrelaszlo]

Ping @knu - any feedback on this PR? :)

[andrelaszlo]

Ping @knu (or perhaps @leejarvis?) - this bug is still present in the library. I tried to follow the instructions in the Contributing section but maybe I missed something? 🤔

[knu]

Sorry for the delay, this looks perfect!