ci: test with ruby 3.3, accommodate new libxml2 behavior #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-33
branch
from
5a03a3d
to
3452150
Compare
As of libxml 2.12.0, the `page.encoding` value inspected by this test is dependent on how libiconv is built (specifically: which aliases are supported). - if alias "UTF8" is defined, then the page encoding will be "UTF-8" - if alias "UTF8" is not defined, then the page encoding will be "UTF8" The modified test started failing on Windows and MacOS (where Nokogiri compiles libiconv and statically links it into the native (precompiled) gem) but still passed on Linux (where libc dynamically provides libiconv symbols).
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-33
branch
from
3452150
to
46482f1
Compare
flavorjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ruby 3.3 to the test matrix.
Also, update an encoding test to pass with the latest libxml2 (v2.12) delivered by the latest nokogiri (v1.16).