ci: truffleruby pipeline tests the new winning compile flag combos

also, let's drop testing stable until the recent TR changes get released
sparklemotion · Mar 11, 2021 · be901fd · be901fd
1 parent f5575c3
commit be901fd
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 25 deletions.
diff --git a/concourse/nokogiri-truffleruby.yml b/concourse/nokogiri-truffleruby.yml
@@ -2,8 +2,14 @@
 
 #@ load("ruby.star", "truffleruby_versions")
 #@ all_truffleruby_versions = []
-#@ all_truffleruby_versions.extend(truffleruby_versions["supported"])
 #@ all_truffleruby_versions.extend(truffleruby_versions["beta"])
+#! 2021-03-10 omit stable until the changes related to nokogiri are shipping in v22
+#! #@ all_truffleruby_versions.extend(truffleruby_versions["supported"])
+
+#@ compile_flag_combos = ["--disable-system-libraries --disable-static",
+#@                        "--disable-system-libraries --enable-static",
+#@                        "--enable-system-libraries",
+#@                       ]
 
 ---
 #@ def registry_image(image_repo, image_tag):
@@ -62,6 +68,7 @@ resources:
         - "Vagrantfile"
 
 jobs:
+#@ previous_job_name = None
 #@ for ruby_version in all_truffleruby_versions:
 #@ job_name = "truffle-{}".format(ruby_version)
   - name: #@ job_name
@@ -70,15 +77,21 @@ jobs:
       - get: ci
       - get: nokogiri
         trigger: true
+        #@ if/end previous_job_name:
+        passed: #@ [previous_job_name]
+      #@ for compile_flags in compile_flag_combos:
       - task: rake-test
         config:
           "_": #@ template.replace(registry_image("flavorjones/nokogiri-test", "truffle-{}".format(ruby_version)))
-          inputs:
-            - name: ci
-            - name: nokogiri
+          inputs: [{name: ci}, {name: nokogiri}]
+          params:
+            COMPILE_FLAGS: #@ compile_flags
           run: { path: ci/concourse/tasks/rake-test/run.sh }
+      #@ end
+#@ previous_job_name = job_name
 #@ end
 
+#@ previous_job_name = None
 #@ for ruby_version in all_truffleruby_versions:
 #@ job_name = "truffle-pr-{}".format(ruby_version)
   - name: #@ job_name
@@ -88,12 +101,16 @@ jobs:
       - get: nokogiri-pr
         trigger: true
         version: every
+        #@ if/end previous_job_name:
+        passed: #@ [previous_job_name]
+      #@ for compile_flags in compile_flag_combos:
       - task: rake-test
         config:
           "_": #@ template.replace(registry_image("flavorjones/nokogiri-test", "truffle-{}".format(ruby_version)))
-          inputs:
-            - name: ci
-            - name: nokogiri-pr
-              path: nokogiri
+          inputs: [{name: ci}, {name: nokogiri-pr, path: nokogiri}]
+          params:
+            COMPILE_FLAGS: #@ compile_flags
           run: { path: ci/concourse/tasks/rake-test/run.sh }
+      #@ end
+#@ previous_job_name = job_name
 #@ end
diff --git a/concourse/nokogiri-truffleruby.yml.generated b/concourse/nokogiri-truffleruby.yml.generated
@@ -1,5 +1,5 @@
 jobs:
-- name: truffle-stable
+- name: truffle-nightly
   plan:
   - get: ci
   - get: nokogiri
@@ -9,21 +9,17 @@ jobs:
         name: ""
         source:
           repository: flavorjones/nokogiri-test
-          tag: truffle-stable
+          tag: truffle-nightly
         type: registry-image
       inputs:
       - name: ci
       - name: nokogiri
+      params:
+        COMPILE_FLAGS: --disable-system-libraries --disable-static
       platform: linux
       run:
         path: ci/concourse/tasks/rake-test/run.sh
     task: rake-test
-  public: true
-- name: truffle-nightly
-  plan:
-  - get: ci
-  - get: nokogiri
-    trigger: true
   - config:
       image_resource:
         name: ""
@@ -34,12 +30,30 @@ jobs:
       inputs:
       - name: ci
       - name: nokogiri
+      params:
+        COMPILE_FLAGS: --disable-system-libraries --enable-static
+      platform: linux
+      run:
+        path: ci/concourse/tasks/rake-test/run.sh
+    task: rake-test
+  - config:
+      image_resource:
+        name: ""
+        source:
+          repository: flavorjones/nokogiri-test
+          tag: truffle-nightly
+        type: registry-image
+      inputs:
+      - name: ci
+      - name: nokogiri
+      params:
+        COMPILE_FLAGS: --enable-system-libraries
       platform: linux
       run:
         path: ci/concourse/tasks/rake-test/run.sh
     task: rake-test
   public: true
-- name: truffle-pr-stable
+- name: truffle-pr-nightly
   plan:
   - get: ci
   - get: nokogiri-pr
@@ -50,23 +64,35 @@ jobs:
         name: ""
         source:
           repository: flavorjones/nokogiri-test
-          tag: truffle-stable
+          tag: truffle-nightly
         type: registry-image
       inputs:
       - name: ci
       - name: nokogiri-pr
         path: nokogiri
+      params:
+        COMPILE_FLAGS: --disable-system-libraries --disable-static
+      platform: linux
+      run:
+        path: ci/concourse/tasks/rake-test/run.sh
+    task: rake-test
+  - config:
+      image_resource:
+        name: ""
+        source:
+          repository: flavorjones/nokogiri-test
+          tag: truffle-nightly
+        type: registry-image
+      inputs:
+      - name: ci
+      - name: nokogiri-pr
+        path: nokogiri
+      params:
+        COMPILE_FLAGS: --disable-system-libraries --enable-static
       platform: linux
       run:
         path: ci/concourse/tasks/rake-test/run.sh
     task: rake-test
-  public: true
-- name: truffle-pr-nightly
-  plan:
-  - get: ci
-  - get: nokogiri-pr
-    trigger: true
-    version: every
   - config:
       image_resource:
         name: ""
@@ -78,6 +104,8 @@ jobs:
       - name: ci
       - name: nokogiri-pr
         path: nokogiri
+      params:
+        COMPILE_FLAGS: --enable-system-libraries
       platform: linux
       run:
         path: ci/concourse/tasks/rake-test/run.sh