Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: bump min supported version of libxml2 to 2.9.2 #3287

Closed
flavorjones opened this issue Jul 7, 2024 · 0 comments · Fixed by #3303
Closed

dep: bump min supported version of libxml2 to 2.9.2 #3287

flavorjones opened this issue Jul 7, 2024 · 0 comments · Fixed by #3303
Milestone

Comments

@flavorjones
Copy link
Member

In #3232 I bumped it to 2.7.7 but it turns out ...

We should also bump the min recommended version to something like 2.12 because Nick's been doing so much great work the last couple of years.

@flavorjones flavorjones added this to the v1.17.0 milestone Jul 7, 2024
flavorjones added a commit that referenced this issue Aug 7, 2024
**What problem is this PR intended to solve?**

I'm deciding to drop support for earlier versions because:

- 2.7.7 nanohttp.c doesn't compile on modern systems
- 2.8.0 doesn't have PARSE_BIG_LINES, GNOME/libxml2@968a03a2 introduced
it in 2.9.0
- 2.9.0 and 2.9.1 have the xpath optimization bug that ruined our CSS
queries in :first-child broken with libxml 2.9.0 #829,
GNOME/libxml2@b4bcba23 fixed it in 2.9.2

Also, bump the min recommended version to v2.12.0 because Nick has fixed
a lot of long-standing issues upstream. ♥ ♥ ♥

Followup to #3232
Closes #3287


**Have you included adequate test coverage?**

Existing coverage is sufficient.


**Does this change affect the behavior of either the C or the Java
implementations?**

No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant