fix parsing in-context of parent #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the need to override `#coerce` and have the logic there.
The choice of context node has no functional impact for Nokogiri per se; but it's necessary for Nokogumbo, which has a better HTML parser, to ensure the parser is in the right state. When testing this change against nodes without a parent, the test suite found memory problems related to libxml2 manipulating pointers on pickled nodes. As a result, the impacted methods now raise a RuntimeError if they're called on a node without a parent (the concept of a sibling or a replacement/swap doesn't make sense without the context of a parent to hold it together, anyway). Note that `Node#coerce` is now a __protected__ method (previously it was __private__). Impacted Node methods: - add_next_sibling, previous=, and before - add_previous_sibling, next=, and after - replace and swap Fixes rubys/nokogumbo#160
|
Code Climate has analyzed commit 46e33cc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
rubys/nokogumbo#160
Have you included adequate test coverage?
👍
Does this change affect the C or the Java implementations?
Changes affect Nokogiri generally, though it has the side effect of bringing the JRuby and CRuby implementations in line with each other with respect to exceptions raised in edge cases.