-
-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run bash scripts on windows runners #2659
Conversation
OK, these 4 remaining failures are real failures when building from source on Windows, I think. Grr. |
a7c7a7c
to
5a5388c
Compare
5a5388c
to
5b57929
Compare
I think I've fixed the failures, which were compiling-nokogumbo-against-nokogiri-built-with-system-libraries. |
ac0d74d
to
f5e45d3
Compare
Still struggling to get the nokogumbo integration test to not fail during linktime. Relevant prior work is at #2167 |
add545a
to
b79f989
Compare
specify ldflags to resolve Nokogiri's symbols.
b79f989
to
f461f9e
Compare
Ugh, it's because Nokogumbo 2.0.4 doesn't have the fixes for the linked flags! 🤦 OK, should be green now. |
f461f9e
to
bec9da5
Compare
What problem is this PR intended to solve?
Run the full test suite against the installed gems on windows systems.