Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext: migrate NodeSet to TypedData api #2824

Merged
merged 2 commits into from
Mar 7, 2023
Merged

ext: migrate NodeSet to TypedData api #2824

merged 2 commits into from
Mar 7, 2023

Commits on Mar 7, 2023

  1. style: variable naming consistency

    @flavorjones
    flavorjones committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0f9c395 View commit details
    Browse the repository at this point in the history

  2. ext: migrate NodeSet to the TypedData API 

    See #2808

Note that I chose to make a new public function,
`noko_xml_node_set_unwrap`, to allow other files to unwrap node
sets. This differs from the tactic adopted in #2807 / cb1557d which
was to make public the data type.

We should probably decide which is the better approach and
standardize on it.
    @flavorjones
    flavorjones committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5a1abf9 View commit details
    Browse the repository at this point in the history